Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a custom node:test reporter #5284

Merged
merged 12 commits into from
May 30, 2024
Merged

Introduce a custom node:test reporter #5284

merged 12 commits into from
May 30, 2024

Conversation

alcuadrado
Copy link
Member

@alcuadrado alcuadrado commented May 28, 2024 •
edited
Loading

This PR introduces a new package with a custom node:test reporter, but doesn't modify the rest of the packages to use it.

The new test reporter has a few objectives:

  1. It tries to look like mocha.
  2. If an error comes from a library using actual and expected (like chai/earl/etc), it diffs those values, printing the diff.
  3. It prints its output as soon as possible but preserves the tests' definition order.

This PR is based on @ChristopherDedominici's work and https://github.com/voxpelli/node-test-pretty-reporter

@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 11:15pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c8ae4cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label May 28, 2024
alcuadrado

This comment was marked as off-topic.

Sign in to view

schaable
schaable approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ChristopherDedominici
ChristopherDedominici approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left 2 small comments but a part from them all good!

@alcuadrado alcuadrado merged commit b8b1d1c into v-next May 30, 2024
46 checks passed
@alcuadrado alcuadrado deleted the test-reporter branch May 30, 2024 23:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schaable schaable schaable approved these changes

@ChristopherDedominici ChristopherDedominici ChristopherDedominici approved these changes

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alcuadrado @schaable @ChristopherDedominici