Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize and Enable E2E tests on Windows #5339

Closed

Conversation

sisco0
Copy link
Contributor

@sisco0 sisco0 commented Jun 5, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This pull request introduces several optimizations to the existing e2e-tests.yml workflow to improve the overall execution time and efficiency of our end-to-end (e2e) tests on GitHub Actions as required in #5247.

Changes Introduced:

  • Re-enable Windows Testing:
    The original workflow had Windows tests disabled due to performance issues and a bug with pnpm. We have re-enabled Windows testing with specific conditions to handle Windows-specific issues, ensuring that pnpm operations are executed correctly.
  • Matrix Strategy Optimization:
    Ensured that the jobs are run in parallel across ubuntu-latest, macos-latest, and windows-latest, reducing the overall execution time.
  • Caching Dependencies:
    Added caching for pnpm modules using actions/cache@v3 to avoid re-downloading and installing dependencies in every run. This change significantly reduces setup time for the jobs.
  • Improved Script Handling:
    Introduced conditional execution of scripts based on the operating system. For non-Windows systems, the scripts are executed as before. For Windows, equivalent PowerShell scripts are used to ensure compatibility.

No testing has been performed over the current solution.

Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: dce45b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 8:58pm

@sisco0 sisco0 marked this pull request as ready for review June 5, 2024 02:32
@sisco0 sisco0 marked this pull request as draft June 5, 2024 02:32
@sisco0 sisco0 marked this pull request as ready for review June 5, 2024 17:00
@alcuadrado
Copy link
Member

I'm a bit confused about this PR, it fails because you are trying to run a file that doesn't exist.

@sisco0
Copy link
Contributor Author

sisco0 commented Jun 5, 2024

Reason behind was PowerShell scripts references, which are not currently present in the project.
Instead of commiting the new PowerShell (.ps1) files, references about these have been removed.
Re-factored the current source-code and pushed the commit for it.
@alcuadrado

@alcuadrado
Copy link
Member

Isn't this removing a comment about a bug without any reason? I don't think this has been fixed, is it?

@sisco0
Copy link
Contributor Author

sisco0 commented Jun 5, 2024

Isn't this removing a comment about a bug without any reason? I don't think this has been fixed, is it?

Comment was restored as requested @alcuadrado .
Agree on the given fact. Ideally, a reference to a Github Issue should be added for properly handling the case actively.
This could be debugged in the future via https://github.com/nektos/act

@alcuadrado
Copy link
Member

Thanks once again for submitting this PR, @sisco0. Unfortunately, we won't be able to prioritize this just yet. Our CI needs are pretty different in our main development branch, so we can't put much effort into this right now.

@alcuadrado alcuadrado closed this Jun 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants