Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve task types & validation #5341

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Improve task types & validation #5341

merged 3 commits into from
Jun 6, 2024

Conversation

schaable
Copy link
Member

@schaable schaable commented Jun 5, 2024

Part of #5229

  • Improves typings.
  • Makes isParameterValueValid work with arrays (for variadic parameters). This will be used for validation in the run function.

@schaable schaable added the v-next A Hardhat v3 development task label Jun 5, 2024
@schaable schaable requested a review from alcuadrado June 5, 2024 15:17
@schaable schaable self-assigned this Jun 5, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:22pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 516fd25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schaable
Copy link
Member Author

schaable commented Jun 5, 2024

I'm going to hold off on merging this until #5334 is merged.

@schaable
Copy link
Member Author

schaable commented Jun 6, 2024

@alcuadrado @ChristopherDedominici Can you double-check that I didn't break anything with the rebase?

@schaable schaable merged commit 67c897c into v-next Jun 6, 2024
50 checks passed
@schaable schaable deleted the tasks-def branch June 6, 2024 20:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

@ChristopherDedominici ChristopherDedominici ChristopherDedominici approved these changes

Assignees

@schaable schaable

Labels
v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schaable @alcuadrado @ChristopherDedominici @kanej