Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGlobalParameterDefinition implementation & testing #5390

Merged
merged 6 commits into from
Jun 19, 2024
Merged

buildGlobalParameterDefinition implementation & testing #5390

merged 6 commits into from
Jun 19, 2024

Conversation

schaable
Copy link
Member

Part of #5379

This should be easy to review by going through it commit by commit.

@schaable schaable added the v-next A Hardhat v3 development task label Jun 13, 2024
@schaable schaable requested a review from alcuadrado June 13, 2024 18:36
@schaable schaable self-assigned this Jun 13, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 6:36pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2024

⚠️ No Changeset found

Latest commit: 5fcb380

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 13, 2024
schaable
schaable commented Jun 13, 2024
View reviewed changes
v-next/core/src/internal/global-parameters.ts
name: string;
description: string;
parameterType: ParameterType;
defaultValue: any;
parameterType?: T;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alcuadrado I think parameterType should be just type to be consistent with task parameters. wdyt? I'll change it on a follow up PR if you agree.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an issue to track it.

@schaable schaable mentioned this pull request Jun 15, 2024
Merged
alcuadrado
alcuadrado approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And agreed with both of your comments

@schaable schaable merged commit 4b68018 into v-next Jun 19, 2024
53 checks passed
@schaable schaable deleted the global-parameters branch June 19, 2024 22:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@schaable schaable

Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schaable @alcuadrado