-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildGlobalParameterDefinition implementation & testing #5390
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
name: string; | ||
description: string; | ||
parameterType: ParameterType; | ||
defaultValue: any; | ||
parameterType?: T; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alcuadrado I think parameterType
should be just type
to be consistent with task parameters. wdyt? I'll change it on a follow up PR if you agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an issue to track it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. And agreed with both of your comments
Part of #5379
This should be easy to review by going through it commit by commit.