Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move parseTaskAndArguments into the tests as a temporary fix for tests #5424

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Jun 24, 2024

Fixes #5410

Ideally, this PR would split the tests into appropriate tests of parseTask and parseTaskArguments, however, there are many tests and the logic for testing both is deeply intertwined in both. Since the underlying logic is the same, I decided to simply make parseTaskAndArguments a test-only function abstraction since I don't think it's worth the dev time right now to fully break out all the tests.

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 3:16pm

Copy link

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: ab95f71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zoeyTM zoeyTM added v-next A Hardhat v3 development task and removed status:triaging labels Jun 24, 2024
@zoeyTM zoeyTM merged commit dc48f55 into v-next Jun 25, 2024
46 checks passed
@zoeyTM zoeyTM deleted the remove-parse-task-and-arguments branch June 25, 2024 19:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v-next A Hardhat v3 development task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants