move parseTaskAndArguments into the tests as a temporary fix for tests #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
zoeyTM
force-pushed
the
remove-parse-task-and-arguments
branch
from
9d61185 to
ab95f71
Compare
alcuadrado
approved these changes
Jun 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5410
Ideally, this PR would split the tests into appropriate tests of
parseTaskandparseTaskArguments, however, there are many tests and the logic for testing both is deeply intertwined in both. Since the underlying logic is the same, I decided to simply makeparseTaskAndArgumentsa test-only function abstraction since I don't think it's worth the dev time right now to fully break out all the tests.