Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package.json from hardhat's tsconfig.json #5441

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

alcuadrado
Copy link
Member

@alcuadrado alcuadrado commented Jun 27, 2024

This PR removes the package.json from hardhat's tsconfig.json.

The main reason this is important is that having the pacakge.json as part of the files that tsc process means that it's copied over to dist/, bringing a few problems tsc when importing hardhat from other packages. With the dist/package.json, it incorrectly thinks that dist/ is the root of the package.

As this was probably added to support example.config.ts in hardhat/, I removed that and moved its contents to example-project/hardhat.config.ts.

Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 3:56pm

Copy link

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: 9a5ebd6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 27, 2024
@alcuadrado alcuadrado requested review from zoeyTM and schaable June 27, 2024 18:05
@alcuadrado
Copy link
Member Author

While testing this @schaable noticed that the example-project was actually broken, as the type extensions of the builtin plugins weren't loaded. I fixed that too.

Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alcuadrado alcuadrado force-pushed the fix-hardhat-tsconfig branch from fcfe067 to 9a5ebd6 Compare June 28, 2024 15:55
@alcuadrado alcuadrado merged commit 186b314 into v-next Jun 28, 2024
45 checks passed
@alcuadrado alcuadrado deleted the fix-hardhat-tsconfig branch June 28, 2024 15:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants