-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove package.json from hardhat
's tsconfig.json
#5441
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
8308390
to
06cebea
Compare
06cebea
to
418cd9e
Compare
While testing this @schaable noticed that the example-project was actually broken, as the type extensions of the builtin plugins weren't loaded. I fixed that too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fcfe067
to
9a5ebd6
Compare
This PR removes the
package.json
fromhardhat
'stsconfig.json
.The main reason this is important is that having the pacakge.json as part of the files that
tsc
process means that it's copied over todist/
, bringing a few problemstsc
when importinghardhat
from other packages. With thedist/package.json
, it incorrectly thinks thatdist/
is the root of the package.As this was probably added to support
example.config.ts
inhardhat/
, I removed that and moved its contents toexample-project/hardhat.config.ts
.