Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove eslint rules from packages in v-next #5448

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

kanej
Copy link
Member

@kanej kanej commented Jun 28, 2024

The two eslint rule packages are the only packages that are referenced in v-next.

To simplify in infra and lives we are going to switch off those rules in v-next for the moment. They can be re-added later.

Specifically this allows us to add the eslint rules to the ignore list of changeset.

Resolves #5447.

The two eslint rule packages are the only packages that are referenced in v-next.

To simplify in infra and lives we are going to switch off those rules in v-next for the moment. They can be re-added later.

Resolves #5447.
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 2:34pm

Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: ccf1233

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 28, 2024
@kanej kanej linked an issue Jun 28, 2024 that may be closed by this pull request
@kanej kanej requested a review from alcuadrado June 28, 2024 10:45
@kanej kanej merged commit 623ed23 into v-next Jun 28, 2024
46 checks passed
@kanej kanej deleted the chore/turn-off-package-eslint-rules-in-vnext branch June 28, 2024 15:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove eslint rules from ./packages from ./v-next
2 participants