Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vnext to typescript 5.5 #5453

Merged
merged 6 commits into from
Jun 28, 2024
Merged

update vnext to typescript 5.5 #5453

merged 6 commits into from
Jun 28, 2024

Conversation

kanej
Copy link
Member

@kanej kanej commented Jun 28, 2024 •
edited
Loading

Update the v-next packages to use typescript v5.5 and enable isolated declarations.

The type determination has been mechanical based on vscode - I have not created any new types.

@vercel Vercel
Copy link

vercel bot commented Jun 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 8:59pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 374ef64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 28, 2024
@kanej kanej force-pushed the chore/update-vnext-to-typescript-5.5 branch from 8df6839 to 1dbd317 Compare June 28, 2024 16:03
@kanej kanej force-pushed the chore/update-vnext-to-typescript-5.5 branch from 1dbd317 to 9103c28 Compare June 28, 2024 16:15
@kanej kanej force-pushed the chore/update-vnext-to-typescript-5.5 branch from 9103c28 to 0aec81d Compare June 28, 2024 16:20
@kanej kanej force-pushed the chore/update-vnext-to-typescript-5.5 branch from 0aec81d to 0271b80 Compare June 28, 2024 16:25
@kanej kanej force-pushed the chore/update-vnext-to-typescript-5.5 branch from 0271b80 to bca5d06 Compare June 28, 2024 16:32
@kanej kanej requested review from schaable and alcuadrado June 28, 2024 16:34
schaable
schaable reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few comments.

@alcuadrado alcuadrado force-pushed the chore/update-vnext-to-typescript-5.5 branch from bc0d98b to 374ef64 Compare June 28, 2024 20:58
@alcuadrado alcuadrado merged commit b09b797 into v-next Jun 28, 2024
46 checks passed
@alcuadrado alcuadrado deleted the chore/update-vnext-to-typescript-5.5 branch June 28, 2024 21:03
@schaable schaable mentioned this pull request Jul 1, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schaable schaable schaable approved these changes

@alcuadrado alcuadrado Awaiting requested review from alcuadrado

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanej @alcuadrado @schaable