Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid top-level-await #5454

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Forbid top-level-await #5454

merged 1 commit into from
Jun 28, 2024

Conversation

alcuadrado
Copy link
Member

@alcuadrado alcuadrado commented Jun 28, 2024

This PR adds a rule to eslint to forbid top-level-await.

We use it in two files, but we shouldn't use it anywhere else. They are the client's entry point and the index of hardhat, both initialize instances of the HRE.

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 3:47pm

Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: ba1c8fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alcuadrado alcuadrado requested a review from schaable June 28, 2024 15:46
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 28, 2024
@alcuadrado alcuadrado merged commit 7ec390f into v-next Jun 28, 2024
50 checks passed
@alcuadrado alcuadrado deleted the no-top-level-await branch June 28, 2024 18:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants