Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tsconfig.json files with ${configDir} #5457

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

alcuadrado
Copy link
Member

TS 5.5 added a ${configDir} variable that you can use in shared configs to define values relative to the actual config dir. This allows you to simplify the shared configurations. This PR takes advantage of that.

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 9:18pm

Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: d47f212

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 28, 2024
@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Jun 28, 2024
This is possible because we use nohoist for @types
@alcuadrado
Copy link
Member Author

I added a second commit using this variable to set the typesRoot to each package's own @types/ packages. Otherwise all the hoisted @types/ get loaded (e.g. prettier's types).

@alcuadrado alcuadrado merged commit a83229b into v-next Jun 28, 2024
46 checks passed
@alcuadrado alcuadrado deleted the simpler-tsconfigs branch June 28, 2024 21:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants