Isolate the build-system package errors #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This was referenced Jun 29, 2024
ChristopherDedominici
approved these changes
Jul 1, 2024
schaable
reviewed
Jul 1, 2024
| @@ -231,21 +195,13 @@ Please add the property "type" with the value "module" in your package.json to e | |||
| number: 100, | |||
| messageTemplate: "An internal invariant was violated: {message}", | |||
| websiteTitle: "Invariant violation", | |||
| websiteDescription: `An internal invariant was violated. This is probably caused by a programming error in Hardhat or in one of the used plugins. | |||
|
|
|||
| websiteDescription: `An internal invariant was violated. This is probably caused by a programming in Hardhat or in one of the used plugins. | |||
There was a problem hiding this comment.
you accidentally removed the word error
schaable
approved these changes
Jul 1, 2024
alcuadrado
commented
Jul 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the build system's descriptors to avoid copying over multiple unnecessary ones.
I did this by copying the required descriptors into the package itself and then deleting everything that was not needed. After removing many descriptors, I also had to reorder them. Reviewing commit by commit may be simpler.
Also, while fixing some errors, I ensured that we weren't using
assert.throwsorassert.rejectswith error messages. Because of that, too many tests were failing after this refactor.