Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unconditional reverts in stack traces tests #5467

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Avoid unconditional reverts in stack traces tests #5467

merged 1 commit into from
Jul 2, 2024

Conversation

fvictorio
Copy link
Member

Closes #5443.

@fvictorio fvictorio requested a review from alcuadrado July 2, 2024 10:06
@vercel Vercel
Copy link

vercel bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 10:08am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: 61c2c0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jul 2, 2024
This was referenced Jul 2, 2024
Closed
Merged
@fvictorio fvictorio added the no changeset needed This PR doesn't require a changeset label Jul 2, 2024
@fvictorio fvictorio merged commit b9227a4 into main Jul 2, 2024
92 of 93 checks passed
@fvictorio fvictorio deleted the stack-traces-tests-conditionals-for-reverts branch July 2, 2024 20:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees
No one assigned
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack trace tests expectations failing upon introducing new optimization in the Solidity compiler
2 participants
@fvictorio @alcuadrado