-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate argument naming #5484
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I just pushed a tiny missing rename.
Let's get this merged asap to avoid future conflicts.
This PR is a significant refactor attempting to consolidate the wording around parameters, arguments, and options. The term "parameter" has been replaced with "argument" in most instances, including tests, for consistency. In some cases, it has been replaced with "options," and in some others, with "definitions". I have tried to break this into smaller refactors, so you should be able to review it commit by commit.
Closes #5420