Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate argument naming #5484

Merged
merged 12 commits into from
Jul 4, 2024
Merged

Consolidate argument naming #5484

merged 12 commits into from
Jul 4, 2024

Conversation

schaable
Copy link
Member

@schaable schaable commented Jul 4, 2024

This PR is a significant refactor attempting to consolidate the wording around parameters, arguments, and options. The term "parameter" has been replaced with "argument" in most instances, including tests, for consistency. In some cases, it has been replaced with "options," and in some others, with "definitions". I have tried to break this into smaller refactors, so you should be able to review it commit by commit.

Closes #5420

@schaable schaable added the v-next A Hardhat v3 development task label Jul 4, 2024
@schaable schaable self-assigned this Jul 4, 2024
Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 9:54pm

Copy link

changeset-bot bot commented Jul 4, 2024

⚠️ No Changeset found

Latest commit: 471c9f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jul 4, 2024
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I just pushed a tiny missing rename.

Let's get this merged asap to avoid future conflicts.

@schaable schaable merged commit 8c4f8ab into v-next Jul 4, 2024
46 checks passed
@schaable schaable deleted the consolidate-argument-naming branch July 4, 2024 22:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants