Use hardhat-test-utils' functions
#5496
Merged
+599
−555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
schaable
reviewed
Jul 8, 2024
| export async function assertRejectsWithHardhatError< | ||
| ErrorDescriptorT extends ErrorDescriptor, | ||
| >( | ||
| f: (() => Promise<any>) | Promise<any>, | ||
| op: (() => Promise<any>) | Promise<any>, | ||
| descritor: ErrorDescriptorT, |
There was a problem hiding this comment.
oops, we missed this in the previous PR. There's a typo here, and it's also present in the other function.
schaable
approved these changes
Jul 8, 2024
alcuadrado
force-pushed
the
use-error-assertions
branch
from
8bdd711 to
250cd29
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new
eslintrules to forbid the error-related assertions thatnode:assert/stricthas, and forces us to use our own instead.It also fixies all the new linter errors, so it's a large and repetitive PR.