Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logic to ask for telemetry consent #5501 #5503

Merged
merged 10 commits into from
Jul 16, 2024
Merged

Implement logic to ask for telemetry consent #5501 #5503

merged 10 commits into from
Jul 16, 2024

Conversation

ChristopherDedominici
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici commented Jul 9, 2024 •
edited
Loading

Link to task

Add logic to ask for telemetry consent.
The consent should be registered but this feature will be implemented in this work item, not here.

There are no tests because the telemetry logic cannot be triggered in the CI

@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 9:29am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5edf1ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ChristopherDedominici
ChristopherDedominici commented Jul 9, 2024
View reviewed changes
v-next/hardhat/src/internal/cli/telemetry/telemetry-consent.ts
// Store user's consent choice
await writeJsonFile(await getTelemetryConsentFilePath(), { consent });

// TODO: this will be enabled in a following PR as soon as the function to send telemetry is implemented
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be done in this work item. These tasks are under the same parent feature

schaable
schaable approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments

alcuadrado
alcuadrado reviewed Jul 10, 2024
View reviewed changes
v-next/hardhat/src/internal/cli/telemetry/telemetry-consent.ts Outdated

function canTelemetryBeEnabled(isHelpCommand: boolean): boolean {
return (
!isHelpCommand &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was here in v2 because telemitry wasn't done using a subprocess and it was slow. We don't need it anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in this commit

alcuadrado
alcuadrado requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few comments

@ChristopherDedominici ChristopherDedominici linked an issue Jul 11, 2024 that may be closed by this pull request
Implement logic to ask for telemetry consent #5501
Closed
@ChristopherDedominici ChristopherDedominici added status:ready This issue is ready to be worked on and removed status:triaging labels Jul 12, 2024
@kanej kanej removed their assignment Jul 12, 2024
@schaable schaable added the v-next A Hardhat v3 development task label Jul 15, 2024
@ChristopherDedominici ChristopherDedominici merged commit 9aac754 into v-next Jul 16, 2024
54 checks passed
@ChristopherDedominici ChristopherDedominici deleted the feature/add-telemetry-consent branch July 16, 2024 04:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schaable schaable schaable approved these changes

@alcuadrado alcuadrado alcuadrado approved these changes

@kanej kanej Awaiting requested review from kanej

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement logic to ask for telemetry consent
4 participants
@ChristopherDedominici @alcuadrado @schaable @kanej