-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User config validation #5528
User config validation #5528
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
d7f7cab
to
eb86284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments. There are two things I'm not completely sure about:
- Doing the validations manually vs using Zod. I think this might be achievable with Zod, and it would probably look nicer. However, I haven't used Zod before, so I could be wrong.
- There are some duplicate validations between this PR and tasks. I'm inclined to say we should remove them either here or in the task manager/builders, unless these validations don't run in some scenarios.
pushed up a commit addressing most of the comments. i'm working on a further update to validate via zod instead, but it won't be ready until tomorrow. |
59e9ef5
to
5d7203c
Compare
After discussing pros/cons with Pato, we agreed that manual validation was the preferred choice as opposed to full config validation via zod. |
5d7203c
to
13b133b
Compare
This PR adds validation for all the currently supported fields in
HardhatUserConfig
(currently justtasks
andplugins
).Fixes #5230