Clean task #5540
Clean task #5540
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
schaable
force-pushed
the
improve-task-types
branch
from
709e8cb to
6339731
Compare
| @@ -196,6 +196,8 @@ async function resolveUserConfig( | |||
| tasks: config.tasks ?? [], | |||
| paths: { | |||
| root: projectRoot, | |||
| cache: config.paths?.cache ?? "", // TODO: resolve cache path | |||
There was a problem hiding this comment.
Do we have a task to properly implement this resolution? Can you create one?
There was a problem hiding this comment.
Maybe these things should be defined in hardhat, not core
There was a problem hiding this comment.
I think it's part of #5524, right?
There was a problem hiding this comment.
@kanej can you confirm?
v-next/hardhat/src/internal/builtin-plugins/clean/task-action.ts
Outdated
Show resolved
Hide resolved
This PR requires #5527
and #5517.The logic to create the
cacheandartifactspaths is missing, as it's outside the scope of this issue. Because of this, the tests are somewhat "manual" – we handle the folders manually to simulate different scenarios. However, this should be acceptable.The build is currently failing because it needs PR #5517 and some additional code (e.g., adding thecacheandartifactsproperties inv-next/core/test/internal/hook-manager.ts).The task might require additional steps, such as calling
artifacts.clearCache?.(), which depends on how the new build system works.