Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor telemetry-consent file and add tests #5557

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Refactor telemetry-consent file and add tests #5557

merged 1 commit into from
Jul 29, 2024

Conversation

ChristopherDedominici
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 5:59pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: af596c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ChristopherDedominici
ChristopherDedominici commented Jul 29, 2024
View reviewed changes
v-next/hardhat/src/internal/cli/main.ts
@@ -67,8 +67,7 @@ export async function main(
return await initHardhat();
}

// TODO: the consent will be enabled in the other PRs related to telemetry
const _telemetryConsent = await getTelemetryConsent();
await ensureTelemetryConsent();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the new logic, the telemetry consent will be read directly when needed.
This function purpose is to ensure that telemetry-consent is registered, so no value needs to be returned

@ChristopherDedominici ChristopherDedominici merged commit 2bd890b into v-next Jul 29, 2024
58 checks passed
@ChristopherDedominici ChristopherDedominici deleted the features/improve-telemetry-consent-functions branch July 29, 2024 19:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schaable schaable schaable approved these changes

@kanej kanej Awaiting requested review from kanej

@zoeyTM zoeyTM Awaiting requested review from zoeyTM

Assignees

@kanej kanej

Labels
status:triaging
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristopherDedominici @schaable @kanej