Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(v3): improve usage of github actions cache #5563

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

galargh
Copy link
Member

@galargh galargh commented Aug 1, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR is a subset of #5301 and, unlike the original, it targets the v-next branch.

In this PR, I split the population of the GitHub Actions cache from its' usage. I do this by adding a new workflow responsible only for generating new GitHub Actions cache entries on changes to the pnpm lockfiles and updating all the other workflows to only read from the cache rather than reading and writing to it. Additionally, I create a helper action which abstracts away environment setup (installation of node, pnpm and cache setup).

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 3:03pm

Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: 38348a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Aug 1, 2024
@galargh galargh force-pushed the galargh/github-actions-caching branch from f38221b to b7f48f2 Compare August 1, 2024 13:55
@galargh galargh force-pushed the galargh/github-actions-caching branch from ff7ee72 to cc5437e Compare August 2, 2024 11:22
@galargh galargh changed the title ci: improve usage of github actions cache ci: improve usage of github actions cache (v3) Aug 2, 2024
@galargh galargh changed the title ci: improve usage of github actions cache (v3) ci(v3): improve usage of github actions cache Aug 2, 2024
@galargh galargh added the no changeset needed This PR doesn't require a changeset label Aug 2, 2024
@galargh galargh force-pushed the galargh/github-actions-caching branch from cc5437e to fafd05e Compare August 2, 2024 11:35
@galargh galargh requested a review from alcuadrado August 2, 2024 11:45
@galargh galargh marked this pull request as ready for review August 2, 2024 11:45
@galargh galargh merged commit 47eae51 into v-next Aug 2, 2024
53 checks passed
@galargh galargh deleted the galargh/github-actions-caching branch August 2, 2024 15:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants