Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade typescript to ~5.5.0 #5587

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

galargh
Copy link
Member

@galargh galargh commented Aug 8, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

We use ${configDir} template variable in our tsconfig.json on v-next (e.g.

"outDir": "${configDir}/dist",
) which has only been released in TypeScript 5.5 (https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-beta/#the-configdir-template-variable-for-configuration-files).

I've noticed it only, because I had my VSCode configured to use the workspace version of TypeScript, and when browsing files in v-next, it'd fail to resolve types.

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 1:46pm

Copy link

changeset-bot bot commented Aug 8, 2024

⚠️ No Changeset found

Latest commit: bae09d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Aug 8, 2024
@galargh galargh added the no changeset needed This PR doesn't require a changeset label Aug 8, 2024
@galargh galargh requested a review from alcuadrado August 8, 2024 13:54
@schaable schaable added the v-next A Hardhat v3 development task label Aug 9, 2024
@alcuadrado
Copy link
Member

I've noticed it only, because I had my VSCode configured to use the workspace version of TypeScript,

I didn't understand the motivation for this PR at first, but I think this setting is the key reason, isn't it? Because I never had a problem, but I don't have that setting enabled (I probably should).

How would this work if it didn't have any version in the root of the project? I'm wondering because we only use that one in the v2 parts of the repo (i.e. packages/), not in the v3 ones.

Having said that, as this didn't create any compilation error in packages/, I don't see any reason not to merge it.

@galargh
Copy link
Member Author

galargh commented Aug 12, 2024

I've noticed it only, because I had my VSCode configured to use the workspace version of TypeScript,

I didn't understand the motivation for this PR at first, but I think this setting is the key reason, isn't it? Because I never had a problem, but I don't have that setting enabled (I probably should).

How would this work if it didn't have any version in the root of the project? I'm wondering because we only use that one in the v2 parts of the repo (i.e. packages/), not in the v3 ones.

Having said that, as this didn't create any compilation error in packages/, I don't see any reason not to merge it.

Yes, exactly.

By default, VSCode looks for TypeScript in the root node_modules. If we don't define typescript dependency at the root level, then the only option it has is to use the VSCode version of TypeScript. Unless one opens individual packages, of course.

@galargh galargh marked this pull request as ready for review August 12, 2024 15:37
@galargh galargh merged commit 1b1c69e into v-next Aug 12, 2024
117 checks passed
@galargh galargh deleted the galargh/typescript-config-dir branch August 12, 2024 15:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants