Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set exit code to 1 on test failures #5687

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

galargh
Copy link
Member

@galargh galargh commented Aug 28, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This is a follow-up to the discussions in #5584 (comment) and https://nomicfoundation.slack.com/archives/C05MKFQJBCH/p1724801183793089?thread_ts=1724682710.005219&cid=C05MKFQJBCH

This PR ensures that both node:test and mocha test runner plugins set the process exit code to 1 instead of a number of failures when they encounter test failures. This ensures our exit code usage is along what's commonly expected, e.g. https://tldp.org/LDP/abs/html/exitcodes.html

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 1:26pm

Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 9bf7217

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Aug 28, 2024
@galargh galargh requested review from alcuadrado and zoeyTM August 28, 2024 14:06
@galargh galargh added this pull request to the merge queue Aug 28, 2024
Merged via the queue into v-next with commit a53a3ef Aug 28, 2024
22 checks passed
@galargh galargh deleted the galargh/exit-codes branch August 28, 2024 14:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants