chore: set exit code to 1 on test failures #5687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the discussions in #5584 (comment) and https://nomicfoundation.slack.com/archives/C05MKFQJBCH/p1724801183793089?thread_ts=1724682710.005219&cid=C05MKFQJBCH
This PR ensures that both node:test and mocha test runner plugins set the process exit code to 1 instead of a number of failures when they encounter test failures. This ensures our exit code usage is along what's commonly expected, e.g. https://tldp.org/LDP/abs/html/exitcodes.html