Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Chaintype type #5772

Merged
merged 9 commits into from
Sep 28, 2024
Merged

Move Chaintype type #5772

merged 9 commits into from
Sep 28, 2024

Conversation

schaable
Copy link
Member

Move ChainType, DefaultChainType, and ChainTypeConfig away from the config types, as they're not specific to the config. They are now under v-next/hardhat/src/types/network.ts. Merge this PR after #5762

@schaable schaable requested a review from alcuadrado September 23, 2024 13:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7c3054d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 5:34pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Sep 23, 2024
@alcuadrado alcuadrado added v-next A Hardhat v3 development task and removed status:ready This issue is ready to be worked on labels Sep 25, 2024
@schaable schaable force-pushed the network-manager-m1-cleanup branch from 3541c81 to ae00903 Compare September 28, 2024 17:21
Base automatically changed from network-manager-m1-cleanup to v-next September 28, 2024 17:30
@schaable schaable added this pull request to the merge queue Sep 28, 2024
Merged via the queue into v-next with commit 2697d7a Sep 28, 2024
34 checks passed
@schaable schaable deleted the move-chaintype-type branch September 28, 2024 17:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees
No one assigned
Labels
v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schaable @alcuadrado