Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump find-up dependency #5798

Conversation

kiriyaga-txfusion
Copy link
Contributor

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Since your plugin uses older versions of find-up and because, we had to extend your register and script-runner. However, we couldn't resolve these dependencies because they rely on internal/errors, which also uses outdated versions. None of the usual solutions, like ignoring or module declarations, worked. Many other dependencies, such as mocha, c8, and eslint, have updated to version 5.0.0. It would be helpful if you could also update your versions

Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: c592846

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 1:18pm

@kiriyaga-txfusion
Copy link
Contributor Author

Hello @kanej,
Any news about this PR?

@alcuadrado
Copy link
Member

Thanks for sending this PR. Unfortunately, if conflicts with #5767

@alcuadrado alcuadrado closed this Oct 25, 2024
@alcuadrado
Copy link
Member

Actually, this help debug the other pr. Thanks you.

find-up 7.0.0 somehow breaks mocha!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants