-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cleanup provider and stack traces logic #6164
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
4dd2b13
to
0a8ff72
Compare
749035b
to
ecd99c3
Compare
v-next/hardhat/src/internal/builtin-plugins/network-manager/edr/utils/convert-to-edr.ts
Outdated
Show resolved
Hide resolved
v-next/hardhat/src/internal/builtin-plugins/network-manager/edr/utils/convert-to-edr.ts
Outdated
Show resolved
Hide resolved
...src/internal/builtin-plugins/network-manager/edr/stack-traces/stack-trace-solidity-errors.ts
Show resolved
Hide resolved
...src/internal/builtin-plugins/network-manager/edr/stack-traces/stack-trace-solidity-errors.ts
Show resolved
Hide resolved
...src/internal/builtin-plugins/network-manager/edr/stack-traces/stack-trace-solidity-errors.ts
Outdated
Show resolved
Hide resolved
v-next/hardhat/src/internal/builtin-plugins/network-manager/edr/edr-provider.ts
Outdated
Show resolved
Hide resolved
v-next/hardhat/src/internal/builtin-plugins/network-manager/edr/edr-provider.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments.
4179cf5
to
a6fe358
Compare
This is the final cleanup PR for the network stack in preparation for the alpha (and ideally the beta). It includes:
hardhatNetworkReset
event in therequest
method, as it no longer makes sense in v3.close
(unset theprovider
for the EDR provider and thedispatcher
for the HTTP provider) and throw an error if therequest
method is called after closing.request
method:InvalidInputError
logic, as it is already handled bygetJsonRpcRequest
.jsonRpcResponse.result
withassertHardhatInvariant
.#handleEdrResponse
function.stack-trace-solidity-errors.ts
by removing TODOs and enhancing overall code flow.