-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent losing typechain types when compiling a subset of contracts #6458
base: v-next
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: dd31e81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6b0283b
to
f7e49db
Compare
f7e49db
to
bc3bd6a
Compare
bc3bd6a
to
dd31e81
Compare
Cool solution, I like it! @alcuadrado wdyt? |
I've checked typechain-ethers and there's no option to "merge" newly added artifacts into an existing type file (hardhat.d.ts). It just uses whatever is passed on allArtifacts |
When compiling a subset of contracts, only the generated artifacts were being passed to typechain, losing the types of any previously generated artifacts.
This PR changes that, so besides passing the current generated artifacts, it passes all available artifacts in the project.
I had to adapt the test cases a bit since apparently on windows the generated files have a different directory structure than in linux/mac when having multiple contracts.
Closes #6311