Use default value for rpcCachePath when running solidity tests #6464
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9f93405 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
antico5
force-pushed
the
edr-cache-default-path
branch
from
fa506a7 to
8e6a92e
Compare
| @@ -121,6 +121,11 @@ export async function resolveSolidityTestUserConfig( | |||
| testsPath = typeof testsPath === "object" ? testsPath.solidity : testsPath; | |||
| testsPath ??= "test"; | |||
|
|
|||
| const solidityTest = { | |||
| rpcCachePath: "edr-cache", | |||
There was a problem hiding this comment.
Shouldn't we be using a subdirectory under our global hardhat cache directory?
Do you also happen to know why "there are no cache cleanup implications."?
I'm a little confused as to who owns/is responsible for this cache dir. Is it hardhat or is it edr?
There was a problem hiding this comment.
I may be missing some context, but what I understood was to use the cache directory that edr is using. It's hardcoded in this line, and it seems that it can't be changed.
I don't know why we should or should not be cleaning this cache directory. Maybe @kanej or @alcuadrado can validate?
There was a problem hiding this comment.
No, let's use the local cache. We can explore later if using the global one in some situations makes sense. But the global one is more opaque.
There was a problem hiding this comment.
cleaning is done by the user with hardhat clean. That cache is never automatically cleaned.
This is how HH2 works, and we never received complains about it.
There was a problem hiding this comment.
Ah, sorry, I meant - shouldn't we use hre.config.paths.cache instead of the edr-cache?
I saw the other comment
| @@ -121,6 +121,11 @@ export async function resolveSolidityTestUserConfig( | |||
| testsPath = typeof testsPath === "object" ? testsPath.solidity : testsPath; | |||
| testsPath ??= "test"; | |||
|
|
|||
| const solidityTest = { | |||
| rpcCachePath: "edr-cache", | |||
There was a problem hiding this comment.
This should be inside config.paths.cache. A subfolder I mean.
There should be a single cache directory in the root of the project.
antico5
force-pushed
the
edr-cache-default-path
branch
from
477552e to
9f93405
Compare
config.solidityTest.rpcCachePathdefaults toedr-cache, which is the directory that edr uses when running a node in fork mode.The motivation for this is that by default, running solidity tests with fork were not using any cache, taking a long time on each run
Closes #6459