Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default http request timeout from 30s to 300s #6467

Open
wants to merge 1 commit into
base: v-next
Choose a base branch
from

Conversation

antico5
Copy link
Contributor

@antico5 antico5 commented Mar 12, 2025

Closes #6439

Scanned the v3 codebase for all potential outgoing http requests. Since they all go through utils/request, it all cleanly resolves to a single default value for timeouts (which we use for connection, headers and body timeout). Increased it to match unidici's defaults.

@antico5 antico5 requested a review from schaable March 12, 2025 18:23
Copy link

changeset-bot bot commented Mar 12, 2025

🦋 Changeset detected

Latest commit: 0de9d32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/hardhat-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 6:59pm

@antico5 antico5 changed the title Increase default timeout from 30s to 300s Increase default http request timeout from 30s to 300s Mar 12, 2025
@schaable
Copy link
Member

Isn't the original issue referring to the default HTTP network timeout, defined in resolveHttpNetwork within v-next/hardhat/src/internal/builtin-plugins/network-manager/config-resolution.ts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

3 participants