feat(slang): state-variable getters, custom errors, and type metadata by hedgar2017 · Pull Request #463 · NomicFoundation/solx

hedgar2017 · 2026-05-28T16:45:51Z

Lowers the contract-surface constructs through the Slang→MLIR pipeline: public state-variable getters, custom-error require, contract-namespace access, and type(..) metadata.

Public state-variable getters: the getter/ module synthesizes a sol.func per public variable off slang's getter type — scalar and reference reads, keyed mapping/array levels (sol.map / sol.gep no_panic_bounds), struct leaves with non-returnable members skipped, and constant initializer folds; immutable and transient variables are loud unimplemented! arms.
External getter dispatch: c.publicVar(keys) and try over a getter classify through the new ExternalCallee, which admits functions and public state variables alike and dispatches getters as static calls.
Custom-error require: require(cond, E(..)) lowers through sol.require with the error's signature, bare and namespace-qualified alike.
Namespace member access: a contract namespace delegates value and place access to its members (C.x = v, Library.CONST).
type(..) metadata: integer min/max, name, interfaceId, and creationCode/runtimeCode through the new sol.object_code wrapper.
Selector folds: error .selector (4-byte) and event .selector (32-byte topic) fold to constants, as does .selector on a getter reference.

Tests: 13 consolidated LIT fixtures (8 dual-oracle against solc --mlir-action=print-init, 5 solx-only); full tester goes 8792 → 9468 passing with zero regressed files.

Copilot

Pull request overview

Adds Slang-frontend support for Solidity’s auto-generated external getters for public state variables by (1) emitting sol.func getter stubs for supported cases and (2) exposing state-variable selectors to the test harness selector-lookup table, improving compatibility with Solidity tests that call these getters.

Changes:

Extend AstEmitter method-identifier collection to include state-variable getter selectors.
Emit external view getter sol.funcs for some public state variables by loading from the computed storage slot and returning the value.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`solx-slang/src/ast/mod.rs`	Adds state-variable signatures/selectors to the method-identifier map returned to the harness.
`solx-slang/src/ast/contract/mod.rs`	Emits MLIR `sol.func` getter bodies for state variables (currently keyed off ABI “no-input” getters).

Copilot

Pull request overview

Copilot reviewed 33 out of 34 changed files in this pull request and generated no new comments.

github-actions · 2026-08-07T13:51:41Z

Coverage Summary

Crate	Line Coverage	Function Coverage
solx	🟢 83.6%	🔴 20.0%
solx-benchmark-converter	🔴 0.0%	🔴 0.0%
solx-codegen-evm	🔴 25.5%	🔴 13.5%
solx-compiler-downloader	🔴 0.0%	🔴 0.0%
solx-core	🔴 38.6%	🔴 47.6%
solx-dev	🔴 2.4%	🔴 3.0%
solx-evm-assembly	🔴 0.0%	🔴 0.0%
solx-mlir	🟡 59.4%	🟡 56.5%
solx-slang	🔴 23.4%	🔴 31.3%
solx-solc-test-adapter	🔴 1.7%	🔴 2.1%
solx-standard-json	🔴 42.8%	🔴 47.7%
solx-tester	🔴 36.5%	🔴 34.3%
solx-utils	🔴 29.7%	🔴 33.3%
solx-yul	🔴 0.0%	🔴 0.0%
Total	🔴 10.9%	🔴 13.1%

Codecov Report | HTML Report | Workflow Run

PavelKopyl

LGTM, thanks!

Adds the getter/ module synthesizing a getter `sol.func` for each public state variable off slang's getter type: scalar (value and reference) reads, keyed mapping/array levels (`sol.map` / `sol.gep` with `no_panic_bounds`), struct leaves with non-returnable members skipped, and constant initializer folds. External getter calls (`c.publicVar(keys)` -> static `sol.ext_call`) and `try` over a getter dispatch through the new `ExternalCallee` classification, which admits functions and public state variables alike. `require(cond, E(..))` lowers custom errors through `sol.require`; a contract namespace delegates value and place access to its members (`C.x = v`, `Library.CONST`); `type(..)` metadata folds to constants: integer min/max, name, interfaceId, and creation/runtime code through `sol.object_code`; error and event `.selector` fold to the selector and topic constants. Immutable and transient getters are loud `unimplemented!` arms. The slang pin moves to the rebased `az-dev-solx-clean`, whose `compute_interface_id` covers only the functions the interface itself declares, matching `type(I).interfaceId`.

A library-qualified callee slipped past the contract-namespace branch into the external classification, which evaluated the library name as a value and panicked on an unrelated invariant. The namespace identifier now dispatches per definition kind, as member access already does.

The getter emission and the ABI method identifiers each re-walked the contract members for the externally visible state variables; the scope owns the full list, so the public subset is collected beside it and lent to both.

Leaf::members re-derived which struct members a getter returns, a second copy of the rule slang applies when it builds the getter's return type: the two lists are zipped, so a divergence would silently drop reads. The slang pin moves to the revision exposing `getter_struct_members()`, and the leaf only recovers where those members sit among the declared ones.

hedgar2017 added the ci:slang Trigger slang unit tests on PR label May 28, 2026

hedgar2017 self-assigned this Jun 1, 2026

hedgar2017 requested a review from Copilot June 1, 2026 05:34

Copilot started reviewing on behalf of hedgar2017 June 1, 2026 05:34 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread solx-slang/src/ast/mod.rs Outdated

Comment thread solx-slang/src/ast/contract/mod.rs Outdated

hedgar2017 force-pushed the feat-slang-state-var-getters branch from 10ae834 to 8e1a543 Compare August 6, 2026 13:56

hedgar2017 added a commit that referenced this pull request Aug 6, 2026

chore: placeholder to retarget PR #463

4281366

hedgar2017 changed the base branch from main to main-slang August 6, 2026 13:57

hedgar2017 force-pushed the feat-slang-state-var-getters branch from 4281366 to 3cc5f59 Compare August 7, 2026 13:38

hedgar2017 changed the title ~~feat(slang): emit external getters for public state variables~~ feat(slang): state-variable getters, custom errors, and type metadata Aug 7, 2026

hedgar2017 requested review from a team and Copilot August 7, 2026 13:42

Copilot started reviewing on behalf of hedgar2017 August 7, 2026 13:43 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

hedgar2017 force-pushed the feat-slang-state-var-getters branch 3 times, most recently from e8b374b to 6371ac5 Compare August 7, 2026 14:48

hedgar2017 marked this pull request as ready for review August 7, 2026 14:51

hedgar2017 force-pushed the feat-slang-state-var-getters branch 2 times, most recently from 105e9e2 to f05a17e Compare August 7, 2026 17:46

PavelKopyl reviewed Aug 11, 2026

View reviewed changes

Comment thread solx-slang/src/contract/function/expression/call/mod.rs Outdated

PavelKopyl reviewed Aug 11, 2026

View reviewed changes

Comment thread solx-slang/src/contract/getter/leaf.rs

PavelKopyl reviewed Aug 11, 2026

View reviewed changes

Comment thread solx-slang/src/contract/getter/mod.rs

PavelKopyl reviewed Aug 11, 2026

View reviewed changes

Comment thread solx-slang/src/contract/mod.rs Outdated

hedgar2017 requested a review from PavelKopyl August 11, 2026 13:54

PavelKopyl approved these changes Aug 11, 2026

View reviewed changes

hedgar2017 added 2 commits August 12, 2026 15:01

refactor(slang): collect the public state variables once

54ffc97

The getter emission and the ABI method identifiers each re-walked the contract members for the externally visible state variables; the scope owns the full list, so the public subset is collected beside it and lent to both.

hedgar2017 force-pushed the feat-slang-state-var-getters branch 2 times, most recently from a8acb11 to ba5a309 Compare August 12, 2026 18:03

hedgar2017 force-pushed the feat-slang-state-var-getters branch from ba5a309 to d67ede1 Compare August 13, 2026 15:23

hedgar2017 enabled auto-merge August 13, 2026 15:23

ci(windows): enable git core.longpaths so cargo can check out slang

b8083cb

hedgar2017 added this pull request to the merge queue Aug 13, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 13, 2026

Navigation Menu

Uh oh!

feat(slang): state-variable getters, custom errors, and type metadata - #463

feat(slang): state-variable getters, custom errors, and type metadata#463
hedgar2017 wants to merge 5 commits into
main-slangfrom
feat-slang-state-var-getters

hedgar2017 commented May 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Aug 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PavelKopyl left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hedgar2017 commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PavelKopyl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hedgar2017 commented May 28, 2026 •

edited

Loading

github-actions Bot commented Aug 7, 2026 •

edited

Loading