Fix unbounded memory usage during async http get requests in rust-igd#1732
Open
tomaszklak wants to merge 4 commits intoLLT-6230-upnp-client-dosfrom
Open
Fix unbounded memory usage during async http get requests in rust-igd#1732tomaszklak wants to merge 4 commits intoLLT-6230-upnp-client-dosfrom
tomaszklak wants to merge 4 commits intoLLT-6230-upnp-client-dosfrom
Conversation
Before the fix, the requests for igd gateway would effectively run in a tight loop without any delay. This causes very high CPU usage on client machine and can trigger DoS.
tomaszklak
commented
Apr 2, 2026
tomaszklak
force-pushed
the
LLT-6230-upnp-client-memory-usage
branch
from
7f9a8ef to
1b223ca
Compare
tomaszklak
force-pushed
the
LLT-6230-upnp-client-dos
branch
from
9041975 to
bb85939
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Before this change, it was possible for the malicious upnp gateway to trigger arbitrary large memory allocations on the client.
Solution
This change caps the memory usage for both the HTTP headers and body.
☑️ Definition of Done checklist