#664 sync scylla Cargo.lock with Cargo.toml#665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Two changes:
Syncs scylla-server Cargo.lock with Cargo.toml by adding the headers v0.4.1 and headers-core v0.3.0 entries that axum-extra's typed-header feature requires. The committed lock was missing them, so the manual scylla docker image workflow, which builds with
cargo build --release --locked, aborted with exit 101 (arm64 hit the lock error directly; amd64 hit a transient index-fetch reset during the same forced re-resolution). Minimal sync: 25 insertions, no version change to any existing crate.Adds --locked to every cargo command in Scylla CI (clippy, build, run, test) so future lock drift fails on every PR rather than only on the manual docker build, which was the gap that let this drift reach develop.
Notes
Regular Scylla CI previously built without --locked, so it silently regenerated the lock in memory and stayed green; only the --locked docker build surfaced the drift. The CI change closes that gap, and this PR's own Scylla CI run now self-verifies the lock is in sync.
Test Cases
Checklist
Closes #664