Skip to content

Fix/support multi relation property #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rimonhanna
Copy link
Contributor

Description

A database with sub-items enabled
Add multiple sub-items to a single "parent" page
Open parent page:
Previously: It showed only the first child/sub-item as the returned recordMap only included the full information of the first, and only the Ids of the others
Now: It attempts to fetch all children/sub-items blocks and shows them as expected

Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-notion-x ✅ Ready (Inspect) Visit Preview Jun 13, 2025 2:44pm
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Jun 13, 2025 2:44pm

@transitive-bullshit
Copy link
Member

hmmmm the minimal example is intentionally minimal and does not support relations / collections.

@rimonhanna does your use case work with the full example? that's meant to handle this case.

@rimonhanna
Copy link
Contributor Author

@transitive-bullshit done

@rimonhanna
Copy link
Contributor Author

best way to test it, is to enable sub item in this collection and create a few sub items to one of the database items

https://react-notion-i5tvrh2a1-saasify.vercel.app/2fea615a97a7401c81be486e4eec2e94

@rimonhanna
Copy link
Contributor Author

@transitive-bullshit any chance this can be merged and released soon? Thanks!

@rimonhanna rimonhanna force-pushed the fix/support-multi-relation-property branch from 64857eb to 0566267 Compare June 13, 2025 14:42
@rimonhanna
Copy link
Contributor Author

@transitive-bullshit rebased and conflicts fixed

@transitive-bullshit
Copy link
Member

@rimonhanna this looks amazing; thank you 🙏

will include in the next release

btw, do you have a quick notion page id I can use to add this to the test suite?

@rimonhanna
Copy link
Contributor Author

https://reactexamples.notion.site

@transitive-bullshit
Copy link
Member

awesome; thanks again, rimon 🙏

@transitive-bullshit
Copy link
Member

ahhh actually, what's the notion id of that page? i can't seem to find it on that site

@rimonhanna rimonhanna deleted the fix/support-multi-relation-property branch June 13, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants