[tx] Pass num_samples field in payload in vLLM request#1015
Open
chiragbhatt311 wants to merge 1 commit intoNovaSky-AI:mainfrom
Open
[tx] Pass num_samples field in payload in vLLM request#1015chiragbhatt311 wants to merge 1 commit intoNovaSky-AI:mainfrom
chiragbhatt311 wants to merge 1 commit intoNovaSky-AI:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly passes the num_samples field to the external vLLM inference engine. The change adds the n parameter to the request payload, which is the standard way to specify the number of samples in OpenAI-compatible APIs. The existing response handling logic is already capable of processing multiple generated sequences, so this change effectively enables the feature. The implementation is straightforward and correct.
pcmoritz
changed the title
Collaborator
|
Thanks a lot for fixing this! I'm in the process of preparing a release at the moment and will test and include this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.