Support for 16kb page size for watermelondb-jni#1919
Merged
radex merged 2 commits intoNozbe:masterfrom Jun 24, 2025
Merged
Conversation
Collaborator
|
Thank you @lennyerik - I'm planning to review and test this internally this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Android apps and app updates will require native libraries to be built with 16kb page size support. This will become a required change by November 1st 2025. Currently, building with watermelondb-jni results in the following two warnings for published apps on Google Play Console:
The update guide recommends this change for CMake projects and after checking the alignment of the x86_64 and arm64-v8a (the two architectures that will require 16kb support) libraries, this change successfully builds with 2**14 alignment.
After some rudimentary testing on the new 16kb page size emulator image WatermelonDB seems to work as usual after this change, at least in the case of our app.