Elementimprovements #166
Open
Elementimprovements #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making combining use same getElementIds function as !ac does Making getElementId call getElementIds
adding variable ids
it saves the voting result to the creator's combcache
Fixing plural for singular
Making suggesting by ID work fixing 1 nonexistent element not being capitalized
Adding multiple *X (ex: *4 Water, *4 Air results in Water+Water+Water+Water+Air+Air+Air+Air) Creating function ApplyMultiplier to deal with multiplier (this made it possible to add this feature)
Adding {text}, {raw} which make following a name and not an ID or multiplier
however {raw} is supposed to ignore separators too which is not implemented
Implementing {raw},making *N work with + as first element . Adding {name} as an alias of {text}. Adding {id} as alias of #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better version of #163
Currently:Adds variable IDs, suggestion result saving to "last" element, and making combination code use same getElementIDs function