Skip to content

fix: replace termopen (deprecated) with jobstart; properly set command and flags #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: v3.0
Choose a base branch
from
+12 −8
Open

fix: replace termopen (deprecated) with jobstart; properly set command and flags #497

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3af82b8
fix: Detect Windows environment and use shellcmdflag
gin31259461 Jul 15, 2025
989d03d
Merge branch 'v3.0' of github.com:gin31259461/nvchad-ui into v3.0
gin31259461 Jul 15, 2025
fac5e72
refactor: replace termopen (deprecated) with jobstart; properly set c…
gin31259461 Sep 4, 2025
788c98e
small update
gin31259461 Sep 5, 2025
fd8b839
fix: setup terminal command cleaner
gin31259461 Sep 26, 2025
30e81a9
small fix
gin31259461 Oct 31, 2025
2be2bab
Merge branch 'NvChad:v3.0' into v3.0
gin31259461 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions lua/nvchad/term/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,23 +93,27 @@ local function create(opts)
local buf_exists = opts.buf
opts.buf = opts.buf or vim.api.nvim_create_buf(false, true)

-- handle cmd opt
-- handle cmd and flag
local shell = vim.o.shell
local cmd = shell
local shellcmdflag = vim.o.shellcmdflag
local cmd = { shell }

if opts.cmd and opts.buf then
cmd = { shell, "-c", format_cmd(opts.cmd) .. "; " .. shell }
else
cmd = { shell }
for flag in string.gmatch(shellcmdflag, "%S+") do
table.insert(cmd, flag)
end

table.insert(cmd, shell)

if vim.uv.os_uname().sysname:find "Windows" ~= nil then
table.insert(cmd, "-NoLogo")
end

M.display(opts)

save_term_info(opts.buf, opts)

opts.termopen_opts = vim.tbl_extend("force", opts.termopen_opts or {}, { detach = false })
if not buf_exists then
vim.fn.termopen(cmd, opts.termopen_opts)
vim.fn.jobstart(cmd, { term = true })
end

vim.g.nvhterm = opts.pos == "sp"
Expand Down