Check that --prefix is given an absolute path#127
Merged
NathanReb merged 1 commit intoOCamlPro:masterfrom Apr 9, 2026
Merged
Conversation
Signed-off-by: Nathan Rebours <nathan.rebours@ocamlpro.com>
NathanReb
force-pushed
the
install-script-prefix-absolute
branch
from
a0198be to
44e8ec4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124
Makeself installation script is ran within the uncompressed archive and not from the
cwdof the user when they run the.runinstaller. If--prefixis passed a relative path, this means the install script will try to copy the archive content within itself and fail.This PR changes the script so that it reject relative paths given to
--prefixand notifies the user.