TESTING/DRAFT Immutable built in types and code generation #3534

marcschier · 2026-02-09T13:22:18Z

Change built in types to readonly structs
Update localized text implementation to use JSON text serializer
Status code with symbolic names
Immutable node ids - no boxing for int identifiers (in nodeId struct)
No boxing for all built in types <= 8 bytes in Variant.
Split user identity token and token handling via token handler Add migration guide for breaking changes

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

Fixes
<Performance Issue>: IsNullTypeId #3533
Fix complex type system test case LoadAllServerDataTypeSystemsAsync(i=92) #3477
Breaking changes migration guide #3425
Getting NodeState for i=68 (PropertyType) returns an object of type BaseDataVariableTypeState #2969
Change implementation of built in types and code generation to generate efficient code leveraging it. #3537

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

Bugfix (non-breaking change which fixes an issue)
Enhancement (non-breaking change which adds functionality)
Test enhancement (non-breaking change to increase test coverage)
Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING doc.
I have signed the CLA.
I ran tests locally with my changes, all passed.
I fixed all failing tests in the CI pipelines.
I fixed all introduced issues with CodeQL and LGTM.
I have added tests that prove my fix is effective or that my feature works and increased code coverage.
I have added necessary documentation (if appropriate).
Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Change built in types to readonly structs Update localized text implementation to use JSON text serializer Status code with symbolic names Immutable node ids No boxing for all built in types <= 8 bytes in Variant. Split user identity token and token handling via token handler Add migration guide for breaking changes

Stack/Opc.Ua/Opc.Ua.sln

…dard into sgen

romanett · 2026-02-10T14:51:57Z

Libraries/Opc.Ua.Gds.Server.Common/ApplicationsNodeManager.cs

            return predefinedNode;
        }

+        private ServiceResult OnAddSelfAdminRolePermissions(


can you explain the benefit and reasoning of this change?
I dont really get what change made this necessary

ValidateRolePermissions checks whether a node has permissions for a roleId. This happens before even "calling". The ones defined by the standard do not include the SelfAdmin RoleId, so that validation fails because i=0 role id (self admin) has no permission of Call.

It is important to expose the SelfAdmin role on the node so that the role permission check passes, hence this code to inject into RolePermissions and into the UserRolePermissions (if the user has the SelfAdmin RoleId).

My assumption why this is needed now is that the RolePermissions for nodes where not generated by model compiler so there were no roles and no roles means anyone can call without a role, and then all checks where happening via AuthorizationHelper "inside the call callback" later.

Another fix could have been to override ValidateRolePermission method which is virtual. But I think this way is best. But tbd.

Comment out exception throwing for idempotent decoding failure.

koepalex · 2026-02-10T22:39:05Z

Fuzzing/common/Fuzz.Tools/Program.cs


+            // TODO: this loads opc ua assembly, but this should not be needed.
+            // but otherwise encoderfactory currently does not get all types.
+            var temp = new AlarmConditionState(null);


Is this still required?

koepalex · 2026-02-10T22:40:40Z

Fuzzing/Encoders/Fuzz/FuzzableCode.BinaryDecoder.cs

-                throw new InvalidOperationException(Utils.Format(
-                    "Idempotent 3rd gen decoding failed. Type={0}.",
-                    encodeableTypeName));
+              //  throw new InvalidOperationException(Utils.Format(


If we don't need this exception anymore we should delete the whole if statement

koepalex · 2026-02-10T22:41:54Z

Libraries/Opc.Ua.Client.ComplexTypes/TypeBuilder/AttributeExtensions.cs

                ],
                // values to assign
-                [structureDefinition.DefaultEncodingId?
+                [structureDefinition.DefaultEncodingId


Is DefaultEncodingId, complexTypeId, binaryEncodingId and xmlEncodingId now guranteed to be not null?

koepalex · 2026-02-10T22:48:10Z

Libraries/Opc.Ua.Client/Session/SessionClientBatched.cs

            return WriteBatchedAsync(requestHeader, nodesToWrite, operationLimit, ct);

-            async Task<WriteResponse> WriteBatchedAsync(
+            async ValueTask<WriteResponse> WriteBatchedAsync(


At least this method uses await, should we really change that to ValueTask?

koepalex · 2026-02-10T22:50:09Z

Docs/MigrationGuide.md

+   - `UserNameIdentityTokenHandler`  
+   - `X509IdentityTokenHandler`
+   - `IssuedIdentityTokenHandler`
+


Could you add a chapter regarding to AsBoxedObject?

koepalex · 2026-02-10T23:12:07Z

Stack/Opc.Ua.Core/Stack/Types/X509IdentityTokenHandler.cs

+        /// <inheritdoc/>
+        public void Dispose()
+        {
+            // TODOL Utils.SilentDispose(m_certificate);


here we are potential leaking native memory

koepalex · 2026-02-10T23:14:40Z

Stack/Opc.Ua.Core/Types/Utils/DataComparer.cs

@@ -314,7 +314,7 @@ public bool CompareDateTime(DateTime value1, DateTime value2)
        /// <param name="value2">Second Value.</param>
        /// <returns>True in case of equal values.
        /// False or ServiceResultException in case of unequal values.</returns>
-        public bool CompareUuid(Uuid value1, Uuid value2)
+        public bool CompareGuid(Uuid value1, Uuid value2)


why renamed to CompareGuid?

koepalex · 2026-02-10T23:15:31Z

Stack/Opc.Ua.Core/Types/Utils/DataGenerator.cs

@@ -827,19 +822,11 @@ public DateTime GetRandomDateTime()
        }

        /// <inheritdoc/>
-        public Guid GetRandomGuid()
+        public Uuid GetRandomGuid()


Should we call ed GetRandomUuid for consistency?

marcschier changed the title ~~TESTING/DRAFT Generate stack and application code using source generators~~ TESTING/DRAFT Immutable built in types and code generation Feb 9, 2026

Always build netstandard2.0 for test projects

428a860

marcschier mentioned this pull request Feb 9, 2026

<Performance Issue>: IsNullTypeId #3533

Open

5 tasks

marcschier added 2 commits February 9, 2026 14:48

Fix docker build

fa232a2

Fix warning

76ce155

marcschier self-assigned this Feb 9, 2026

Fix docker build

92fa5bb

romanett reviewed Feb 10, 2026

View reviewed changes

Stack/Opc.Ua/Opc.Ua.sln Outdated Show resolved Hide resolved

marcschier added 6 commits February 10, 2026 10:19

Provide correct role permissions for self admin role

6d57b3d

Fix tests and cleanup

6e838ee

Merge with master

6e96556

Merge branch 'master' of https://github.com/OPCFoundation/UA-.NETStan…

b2e86ac

…dard into sgen

Try fix test

30e4c8a

Update

9d11ce3

romanett reviewed Feb 10, 2026

View reviewed changes

Comment out exception for decoding failure

74dbfd1

Comment out exception throwing for idempotent decoding failure.

koepalex reviewed Feb 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TESTING/DRAFT Immutable built in types and code generation #3534

TESTING/DRAFT Immutable built in types and code generation #3534

marcschier commented Feb 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

romanett Feb 10, 2026

Uh oh!

marcschier Feb 10, 2026

Uh oh!

koepalex Feb 10, 2026

Uh oh!

koepalex Feb 10, 2026

Uh oh!

koepalex Feb 10, 2026

Uh oh!

koepalex Feb 10, 2026

Uh oh!

koepalex Feb 10, 2026

Uh oh!

koepalex Feb 10, 2026

Uh oh!

koepalex Feb 10, 2026

Uh oh!

koepalex Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TESTING/DRAFT Immutable built in types and code generation #3534

Are you sure you want to change the base?

TESTING/DRAFT Immutable built in types and code generation #3534

Conversation

marcschier commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Related Issues

Types of changes

Checklist

Further comments

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marcschier commented Feb 9, 2026 •

edited

Loading