add FindIssuerCAByKeyIdentifierAsync#3535
Merged
marcschier merged 2 commits intoOPCFoundation:masterfrom Feb 10, 2026
Merged
Conversation
marcschier
approved these changes
Feb 10, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3535 +/- ##
==========================================
+ Coverage 51.86% 59.99% +8.12%
==========================================
Files 370 378 +8
Lines 78618 78969 +351
Branches 13650 13808 +158
==========================================
+ Hits 40779 47377 +6598
+ Misses 33705 27176 -6529
- Partials 4134 4416 +282 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
romanett
reviewed
Feb 10, 2026
| } | ||
| X509Certificate2 certCA = | ||
| await X509Utils | ||
| .FindIssuerCABySerialNumberAsync( |
Contributor
There was a problem hiding this comment.
is this method also used in other places to find CA, then we should fix it in al places, or maybe even combine into a single method that checks both and deprecate the existing FindIssuerCABySerialNumberAsync
Contributor
Author
There was a problem hiding this comment.
this is the only place where this method was used.
romanett
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...