use longest match instead of endsWith

[simonLeary42]

idFromToken expects the token argument to be a form element ID in MountainCase, but the argument can actually include arbitrary trailing characters:

ondemand/apps/dashboard/app/javascript/dynamic_forms.js

Line 757 in 87e93f6

let match = str.match(`^${token}{1}`);

But then later during an edge case, idFromToken expects an exact match:

ondemand/apps/dashboard/app/javascript/dynamic_forms.js

Line 778 in 87e93f6

return element.endsWith(snake_case_str);

In this case, trailing characters would result in an index-out-of-bounds error. A more reliable way to handle this edge case would be to compare the string length of the matches.

I am assuming that there is a legitimate use case for arbitrary trailing characters. If not, this is completely pedantic. A $ could be added to the end of the regex, but it doesn't make much of a difference. The test case still might be worth keeping, though.

[simonLeary42]

marked as draft until I add test cases

[simonLeary42]

Actually, I don't think this is correct. If your token is cluster, and you match both cluster and cluster_file_system, then the string length of the match will be the same for both.

edit: Actually it's fine. You can't match cluster_file_system if you search for cluster. The form element ID is allowed to be a substring of the token argument, not the other way around. cluster_file_system is not a substring of cluster.