t.rast.import.netcdf: Support ACDD time definition #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In EODAG 3.0, kwarg for download _outputs_prefix_ has been renamed to _output_dir_. See: https://eodag.readthedocs.io/en/stable/breaking_changes.html#b3 This PR adjust the kwarg name accordingly.
Co-authored-by: Hamed Elgizery <[email protected]>
Co-authored-by: Hamed Elgizery <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nilason
reviewed
Nov 12, 2025
src/temporal/t.rast.import.netcdf/testsuite/test_t_rast_import_netcdf_sentinel.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds (minimalistic) support for the data following the Attribute Convention for Data Discovery (ACDD) instead of CF-1.X.
Some format improvements were done for improved ruff-compliance.
Getting time from ACDD metadata was needed for reading SWOT raster data. Which comes with variables with only 2 dimensions and start and end time in a global dataset attribute... ACDD seems common enough to support such cases...
P.S.: Not sure why those old commits show up. I guess my grass8 branch is not perfectly clean. But only the two relevant files were modified anyway...