-
-
Notifications
You must be signed in to change notification settings - Fork 373
build: move config.h.in customizations to configure.ac #6509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
config.h.in purely reconfigurable Some obsolete code removed, LFS detection modernized Contains files regenerated with autoconf 2.72
|
LFS MinGW workaround was required ~15 years a go (see https://trac.osgeo.org/grass/ticket/1131 for its introduction). We break LFS on classic 32bit MinGW (long dead), but not on modern MinGW-w64 that we use. |
|
On what OSes is autoconf 2.72 available now? And for posterity (and me possibly wanting to automate again), what are the instructions needed for regenerating all? |
|
Changes are not autoconf 2.72 specific and thus should be fine also on (a bit) older versions. Besides, as long as we ship generated files, there is little need to regenerate files.
|
wenzeslaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the big change is that we are now using different tools to generate configure (and newly also config.h.in). Is that right?
Looks good to me otherwise.
I was wrong. Minimum autoconf version is 2.71: #2281 |
The big change is that we keep our custom build tweaks in Changes in |
|
Sorry to chime in this late, very busy days behind me. Great work to clean up the (Just wish you would have separated the unrelated 2.72 changes to a PR in its own, for clearer history). |
|
Just noticed that current builds show up with |
|
That is an AMD64 build system – LFS on it is a no-op as it supports 64 bits natively. Please test in a 32 bit environment to see if LFS is handled correctly (we don't have any 32bit machine in our CI). |
It allows config.h.in to be purely reconfigurable
Some obsolete code removed, LFS detection modernized
Contains files regenerated with autoconf 2.72
See discussion in #6479