wxGUI: Read combobox thumbnails from gui/images instead of docs#7750
Open
petrasovaa wants to merge 1 commit into
Open
wxGUI: Read combobox thumbnails from gui/images instead of docs#7750petrasovaa wants to merge 1 commit into
petrasovaa wants to merge 1 commit into
Conversation
The color table, barscale, and north arrow selection widgets loaded their thumbnails from the legacy HTML documentation tree. Generate them into gui/images in both build systems regardless of the documentation options and read them from there; the documentation trees keep their own copies, now generated only when docs are built. Implemented with AI assistance (Claude Fable).
github-actions
Bot
added
GUI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GUI's color table, barscale, and north arrow comboboxes load their thumbnail previews from
$GISBASE/docs/html/, a runtime dependency of the GUI on the legacy HTML documentation tree, which is being phasedout (noticed in the #7719 review discussion).
This moves the runtime copies to
$GISBASE/gui/images/, next to the GUI's other image assets: both build systems generate them there regardless of the documentation options, and the GUI reads them from there. The documentation trees keep their own copies for the manual pages, now consistently generated only when documentation is built.Implemented with AI assistance (Claude Fable).