-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add recreate-stateful-strategy, orphan, background, foreground(default) #1286
Merged
drivebyer
merged 5 commits into
OT-CONTAINER-KIT:main
from
husnialhamdani:recreate-statefulset-strategy
Mar 21, 2025
Merged
feat: add recreate-stateful-strategy, orphan, background, foreground(default) #1286
drivebyer
merged 5 commits into
OT-CONTAINER-KIT:main
from
husnialhamdani:recreate-statefulset-strategy
Mar 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a6248a
to
3797e48
Compare
cd1cd73
to
1362126
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
=======================================
Coverage ? 34.48%
=======================================
Files ? 56
Lines ? 6043
Branches ? 0
=======================================
Hits ? 2084
Misses ? 3777
Partials ? 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…default) Signed-off-by: Husni Alhamdani <[email protected]>
…default) Signed-off-by: Husni Alhamdani <[email protected]>
Signed-off-by: yangw <[email protected]>
Signed-off-by: yangw <[email protected]>
7b9dc25
to
7469004
Compare
Signed-off-by: yangw <[email protected]>
I add the docs and abstract common function for the PR |
drivebyer
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will expand the capability of current
"redis.opstreelabs.in/recreate-statefulset"
, to make the users have more control to deal with recreating process of the StatefulSet,For example: Recreating the Statefulset (with foreground delete) on, will make the Pod of Sentinel entirely terminated,
with the setting of orphan -->
"redis.opstreelabs.in/recreate-statefulset-strategy: orphan"
will keep the Pod up and running and will make the administrator have more control on it (for example: to avoid downtime).Description
Fixes #ISSUE
Type of change
Checklist
Additional Context