Skip to content

Fix code scanning alert no. 28: Uncontrolled data used in path expression #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix code scanning alert no. 28: Uncontrolled data used in path expression #929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3b9a71
Fix code scanning alert no. 28: Uncontrolled data used in path expres…
Ali-Razmjoo Sep 30, 2024
97ef714
Update core.py
Ali-Razmjoo Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nettacker/api/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,12 @@
Returns:
content of the file or abort(404)
"""
if not os.path.normpath(filename).startswith(str(Config.path.web_static_dir)):
base_path = str(Config.path.web_static_dir)
fullpath = os.path.normpath(os.path.join(base_path, filename))
if not fullpath.startswith(base_path):
abort(404)
try:
return open(filename, "rb").read()
return open(fullpath, "rb").read()

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
Loading
.

Copilot Autofix

AI about 1 year ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

except ValueError:
abort(404)
except IOError:
Expand Down