feat(ollama): make tool_call interception configurable#7
Open
feat(ollama): make tool_call interception configurable#7
Conversation
OllamaProvider hardcodes tool_call: True for all models, causing llmspy to intercept tool_calls and execute them server-side via g_exec_tool(). When llmspy is used as a proxy (e.g. for OpenClaw), the client needs tool_calls returned in the response, not executed by llmspy. Add tool_call_enabled attribute to OllamaProvider, sourced from providers.json kwargs (defaults to True for backwards compat). Setting "tool_call": false in providers.json makes tool_calls pass through to the client untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_callbehavior configurable per-provider viaproviders.jsonOllamaProviderhardcodestool_call: Truefor all discovered models, causing llmspy to intercept tool_calls and execute them server-side viag_exec_tool()"tool_call": falsein the ollama provider config makes tool_calls pass through untouchedTruefor full backwards compatibilityTest plan
tool_call: true(default, existing behavior)tool_call: falsein providers.json