fix: Friendships not being properly deleted after account deletion

Author: atlas-oc

lib/octocon/accounts.ex

@@ -17,17 +17,7 @@ defmodule Octocon.Accounts do
     UserRegistry
   }
 
-  alias Octocon.Alters.{
-    Alter,
-    AlterWithProxies
-  }
-
-  alias Octocon.Tags.{
-    AlterTag,
-    Tag
-  }
-
-  alias Octocon.Polls.Poll
+  alias Octocon.Alters.Alter
 
   alias Octocon.Journals.{
     AlterJournalEntry,
@@ -819,6 +809,30 @@ defmodule Octocon.Accounts do
       where: gw.user_id == ^system_id
     )
     |> Repo.delete_all_regional({:user, {:system, system_id}})
+
+    from(
+      f in Octocon.Friendships.Friendship,
+      where: f.user_id == ^system_id
+    )
+    |> Repo.delete_all_global()
+
+    from(
+      f in Octocon.Friendships.Friendship,
+      where: f.friend_id == ^system_id
+    )
+    |> Repo.delete_all_global()
+
+    from(
+      f in Octocon.Friendships.Request,
+      where: f.from_id == ^system_id
+    )
+    |> Repo.delete_all_global()
+
+    from(
+      f in Octocon.Friendships.Request,
+      where: f.to_id == ^system_id
+    )
+    |> Repo.delete_all_global()
   end
 
   @doc """
@@ -1059,5 +1073,7 @@ defmodule Octocon.Accounts do
     end)
 
     :ok
+  rescue
+    e -> {:error, e}
   end
 end

priv/repo/migrations/20260119043444_add_friendships_index.exs

@@ -0,0 +1,15 @@
+defmodule Octocon.Repo.Migrations.AddFriendshipsIndex do
+  use Ecto.Migration
+
+  def change do
+    create_index("global", "friendships", "friend_id")
+  end
+
+  def create_index(keyspace, table, field) when is_binary(keyspace) and is_binary(table) and is_binary(field) do
+    name = "#{table}_by_#{field}"
+
+    execute """
+    CREATE INDEX IF NOT EXISTS #{name} ON #{keyspace}.#{table} (#{field})
+    """, "DROP INDEX #{keyspace}.#{name}"
+  end
+end