Skip to content

core: Add null check to Transaction.MarshalBinary() #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KolbyML wants to merge 1 commit into
base: master
Choose a base branch
from
Open

core: Add null check to Transaction.MarshalBinary() #593

KolbyML wants to merge 1 commit into from

Conversation

@KolbyML
Copy link
Member

@KolbyML KolbyML commented Dec 4, 2025 •
edited
Loading

resolves NIT-4157

Pulled in by OffchainLabs/nitro#4105

MarshalBinary() could panic if someone manually constructed a transaction, a few tests in system_tests were panicking

@KolbyML KolbyML changed the title Add null check to Transaction.MarshalBinary() core: Add null check to Transaction.MarshalBinary() Dec 4, 2025
@KolbyML KolbyML mentioned this pull request Dec 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmikolajczyk41 pmikolajczyk41 pmikolajczyk41 approved these changes

@ganeshvanahalli ganeshvanahalli Awaiting requested review from ganeshvanahalli

Assignees

@joshuacolvin0 joshuacolvin0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KolbyML @pmikolajczyk41 @ganeshvanahalli @joshuacolvin0