Remove manual view lifecycle calls from presentation controller#27
Merged
Merged
Conversation
Remove explicit beginAppearanceTransition and endAppearanceTransition calls for the presenting view controller. As a standard modal presentation, UIKit automatically manages the presenting view controller's lifecycle, making manual calls unnecessary and potentially problematic. This change aligns the implementation with UIKit's standard modal presentation behavior and removes non-standard lifecycle management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes explicit
beginAppearanceTransitionandendAppearanceTransitioncalls for the presenting view controller inFloatingBottomSheetPresentationController.Motivation
As a standard modal presentation, UIKit automatically manages the presenting view controller's lifecycle. Manually calling appearance transition methods is non-standard and can lead to:
Changes
beginAppearanceTransition(false, animated:)calls inpresentationTransitionWillBegin()endAppearanceTransition()call inpresentationTransitionDidEnd(_:)beginAppearanceTransition(true, animated:)calls indismissalTransitionWillBegin()endAppearanceTransition()call indismissalTransitionDidEnd(_:)Impact
This change aligns the implementation with UIKit's standard modal presentation behavior. The presenting view controller's lifecycle will now be managed automatically by UIKit, as expected in standard modal presentations.