fix(chaining): add WorkflowUpdateEvent for legacy feature flag (#4824)#6499
fix(chaining): add WorkflowUpdateEvent for legacy feature flag (#4824)#6499EvaE-Filigran wants to merge 12 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to restore inject chaining notifications when execution traces are ingested through the legacy REST callback path (triggered by LEGACY_INGESTION_EXECUTION_TRACE), by adding @WorkflowUpdateEvent to InjectExecutionService.handleInjectExecutionCallback.
Changes:
- Add
@WorkflowUpdateEventon the legacy execution-trace callback handler inInjectExecutionService. - Import
WorkflowUpdateEventinto the legacy inject execution service.
| @Resource protected ObjectMapper mapper; | ||
|
|
||
| @Transactional | ||
| @WorkflowUpdateEvent(injectId = "#injectId") |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (2.94%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6499 +/- ##
============================================
- Coverage 44.67% 44.65% -0.03%
- Complexity 7619 7622 +3
============================================
Files 2321 2321
Lines 64607 64614 +7
Branches 8574 8575 +1
============================================
- Hits 28864 28852 -12
- Misses 33911 33931 +20
+ Partials 1832 1831 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a6a67c0 to
3c13cff
Compare
impolitepanda
left a comment
There was a problem hiding this comment.
Re approved after fixes from tests









Proposed changes
@WorkflowUpdateEventannotation on the legacy REST API callback path (InjectExecutionService.handleInjectExecutionCallback) so that the inject chaining pipeline is notified when execution traces are processed via the legacy routeTesting Instructions
LEGACY_INGESTION_EXECUTION_TRACEfeature flag (or usemain-ffwhere all flags are active)Checklist
Further comments
On
main-ff, all feature flags are enabled (FEATURE_FLAG_ALL = "*"), includingLEGACY_INGESTION_EXECUTION_TRACE. This forces execution traces to always go through the legacy REST API callback instead of the queue path. The callback was missing@WorkflowUpdateEvent, so the chaining system was never notified of inject completion — steps never received outputs and conditions were never evaluated.