Skip to content

chore: update NestJS dependency to v11 #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2025

Conversation

estiller
Copy link
Contributor

Update the NestJS dependency to use v11.
This should solve #862 regarding issues with peer dependencies in NestJS.

@estiller estiller marked this pull request as ready for review January 23, 2025 00:12
@estiller estiller mentioned this pull request Jan 23, 2025
@wing328
Copy link
Member

wing328 commented Jan 23, 2025

build failed:

error @nestjs/[email protected]: The engine "node" is incompatible with this module. Expected version ">= 20". Got "18.20.5"

given that node 18 is still supported, I think we will need to delay the upgrade for at least a few months: https://endoflife.date/nodejs

@MathieuGuillet
Copy link

MathieuGuillet commented Feb 28, 2025

given that node 18 is still supported, I think we will need to delay the upgrade for at least a few months: https://endoflife.date/nodejs

Hello @wing328 👋
I understand your concern about retrocompatibility. But as node 18 maintenance will stop in next April, the projects that are still using it will have to upgrade eventually. They can still stick to the current version until then, can't they?

This current dependency to nest v10 is blocking a whole chain of dependency update on my project, and I think that we are not the only one in that case.
Is it possible to merge this PR and deliver a new version of openapi-generator-cli ?
Thanks 🙏

@MathieuGuillet
Copy link

Hello @wing328 👋,
any new considerations concerning for this PR ?
Thanks

@wing328
Copy link
Member

wing328 commented Mar 30, 2025

please resolve the merge conflicts, update CI to test with node v20 so that all tests pass

then I'll get it merged :)

@MathieuGuillet
Copy link

Hello @estiller !
Would you have a moment to resolve the conflicts on this PR ? I would help if I can, but I do not have the permission.
Many thanks 👍

@estiller
Copy link
Contributor Author

Here you go

Copy link

@MathieuGuillet MathieuGuillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @wing328 !
This PR is ready to be merged 🎉 🙏
Thank you so much @estiller !

@wing328
Copy link
Member

wing328 commented Apr 16, 2025

thank you. will merge once all tests pass

@wing328 wing328 merged commit c1faf74 into OpenAPITools:master Apr 16, 2025
3 checks passed
Copy link

🎉 This PR is included in version 2.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wing328
Copy link
Member

wing328 commented Apr 16, 2025

@estiller thanks again for the PR, which has been merged and released.

Quick question: do we need to update @type/node to v20.x as well?

related pr: #907

@wing328
Copy link
Member

wing328 commented Apr 16, 2025

fyi. did a test locally and the result is good

C:\Users\wing3>npm uninstall -g @openapitools/openapi-generator-cli

up to date in 657ms

C:\Users\wing3>npm install -g @openapitools/openapi-generator-cli

added 162 packages in 21s

36 packages are looking for funding
  run `npm fund` for details

C:\Users\wing3>openapi-generator-cli generate -g ruby -i https://raw.githubusercontent.com/OpenAPITools/openapi-generator/master/modules/openapi-generator/src/test/resources/3_0/petstore.yaml -o C:\temp\ruby-client
Download 7.11.0 ...
Downloaded 7.11.0
[main] INFO  o.o.codegen.DefaultGenerator - Generating with dryRun=false
[main] INFO  o.o.codegen.DefaultGenerator - OpenAPI Generator: ruby (client)
[main] INFO  o.o.codegen.DefaultGenerator - Generator 'ruby' is considered stable.

@estiller
Copy link
Contributor Author

@estiller thanks again for the PR, which has been merged and released.

Quick question: do we need to update @type/node to v20.x as well?

related pr: #907

It's probably a good idea, regardless of this change, if support is dropped for v18.

@wing328
Copy link
Member

wing328 commented Apr 16, 2025

do you mind filing a PR for that when you've time? 🙏

@estiller
Copy link
Contributor Author

do you mind filing a PR for that when you've time? 🙏

#911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants